#134 Using abbreviated attack names leads to incorrect names in label files

已關閉
stefan.schmidt6 年之前創建 · 1 條評論

ID2T allows the use of abbreviated names when specifying the attack name. The correct name is then generated with the help of difflib in AttackController.choose_attack, but create_attack, which calls choose_attack, uses the name the user specified when generating the label. So the (abbreviated) name the user specified ends up in the label file, instead of the full name, which breaks the code responsible for reading back label files.

The most simple solution would be to move the call to choose_attack from create_attack to process_attack, but other solutions might be better.

ID2T allows the use of abbreviated names when specifying the attack name. The correct name is then generated with the help of difflib in AttackController.choose_attack, but create_attack, which calls choose_attack, uses the name the user specified when generating the label. So the (abbreviated) name the user specified ends up in the label file, instead of the full name, which breaks the code responsible for reading back label files. The most simple solution would be to move the call to choose_attack from create_attack to process_attack, but other solutions might be better.
Jens Keim commented 6 年之前
協同者

Fixed with pull request #144.

Fixed with pull request #144.
Sign in to join this conversation.
未選擇標籤
Bug
未選擇里程碑
未指派成員
2 參與者
正在加載...
取消
保存
尚未有任何內容