#134 Using abbreviated attack names leads to incorrect names in label files

Stängd
öppnade 6 år sedan av stefan.schmidt · 1 kommentarer

ID2T allows the use of abbreviated names when specifying the attack name. The correct name is then generated with the help of difflib in AttackController.choose_attack, but create_attack, which calls choose_attack, uses the name the user specified when generating the label. So the (abbreviated) name the user specified ends up in the label file, instead of the full name, which breaks the code responsible for reading back label files.

The most simple solution would be to move the call to choose_attack from create_attack to process_attack, but other solutions might be better.

ID2T allows the use of abbreviated names when specifying the attack name. The correct name is then generated with the help of difflib in AttackController.choose_attack, but create_attack, which calls choose_attack, uses the name the user specified when generating the label. So the (abbreviated) name the user specified ends up in the label file, instead of the full name, which breaks the code responsible for reading back label files. The most simple solution would be to move the call to choose_attack from create_attack to process_attack, but other solutions might be better.
Jens Keim kommenterad 6 år sedan
Deltagare

Fixed with pull request #144.

Fixed with pull request #144.
Logga in för att delta i denna konversation.
Ingen Etikett
Bug
Ingen Milsten
Ingen förvärvare
2 Deltagare
Laddar...
Avbryt
Spara
Det finns inget innehåll än.