#134 Using abbreviated attack names leads to incorrect names in label files

Gesloten
6 jaren geleden werd geopend door stefan.schmidt · 1 opmerkingen

ID2T allows the use of abbreviated names when specifying the attack name. The correct name is then generated with the help of difflib in AttackController.choose_attack, but create_attack, which calls choose_attack, uses the name the user specified when generating the label. So the (abbreviated) name the user specified ends up in the label file, instead of the full name, which breaks the code responsible for reading back label files.

The most simple solution would be to move the call to choose_attack from create_attack to process_attack, but other solutions might be better.

ID2T allows the use of abbreviated names when specifying the attack name. The correct name is then generated with the help of difflib in AttackController.choose_attack, but create_attack, which calls choose_attack, uses the name the user specified when generating the label. So the (abbreviated) name the user specified ends up in the label file, instead of the full name, which breaks the code responsible for reading back label files. The most simple solution would be to move the call to choose_attack from create_attack to process_attack, but other solutions might be better.
Jens Keim reageerde 6 jaren geleden
Medewerker

Fixed with pull request #144.

Fixed with pull request #144.
Sign in to join this conversation.
Geen mijlpaal
Geen verantwoordelijke
2 deelnemers
Laden...
Annuleren
Opslaan
Er is nog geen inhoud.