#134 Using abbreviated attack names leads to incorrect names in label files

Fechado
há 6 anos atrás aberto por stefan.schmidt · 1 comentários

ID2T allows the use of abbreviated names when specifying the attack name. The correct name is then generated with the help of difflib in AttackController.choose_attack, but create_attack, which calls choose_attack, uses the name the user specified when generating the label. So the (abbreviated) name the user specified ends up in the label file, instead of the full name, which breaks the code responsible for reading back label files.

The most simple solution would be to move the call to choose_attack from create_attack to process_attack, but other solutions might be better.

ID2T allows the use of abbreviated names when specifying the attack name. The correct name is then generated with the help of difflib in AttackController.choose_attack, but create_attack, which calls choose_attack, uses the name the user specified when generating the label. So the (abbreviated) name the user specified ends up in the label file, instead of the full name, which breaks the code responsible for reading back label files. The most simple solution would be to move the call to choose_attack from create_attack to process_attack, but other solutions might be better.
Jens Keim comentado há 6 anos atrás
Colaborador

Fixed with pull request #144.

Fixed with pull request #144.
Faça login para participar desta conversação.
Sem Objetivo
Sem utilizador atribuido
2 Participantes
A carregar...
Cancelar
Guardar
Ainda não existe conteúdo.