Home Explore Help
Sign In
SPIN
/
ID2T-toolkit
6
5
Fork 2
Files Issues 20 Pull Requests 0 Wiki
Labels Milestones
New Pull Request

#145 Fix for relative paths

Merged
jens.klein merged 1 commits from stefan.schmidt/relative_path_fix into SPIN/master 5 years ago
Conversation 0 Commits 1 Files changed 1
Stefan Schmidt commented 5 years ago

This should fix #115.

The underlying problem was that the id2t-script changed the current directory, rendering the specified path wrong if it was relative. This removes the directory changing and instead calls the python script with its full path, keeping the relative path intact.

This has the potential to break some attacks if there are any improperly specified paths left in the ID2T code, so we should probably thoroughly test this.

This should fix #115. The underlying problem was that the id2t-script changed the current directory, rendering the specified path wrong if it was relative. This removes the directory changing and instead calls the python script with its full path, keeping the relative path intact. This has the potential to break some attacks if there are any improperly specified paths left in the ID2T code, so we should probably thoroughly test this.
jens.klein closed 5 years ago
This pull request has been merged successfully!
Sign in to join this conversation.
Labels
Clear labels
Bug Documentation Enhancement
No Label
Bug
Documentation
Enhancement
Milestone
Clear milestone
No Milestone
Assignee
Clear assignee
No assignee
1 Participants
Write Preview
Loading...
Cancel
Save
There is no content yet.