#109 Fix for corrupt test-pcap

Слито
carlos.garcia слито 1 коммит(ов) из stefan.schmidt/reg_test_fix в SPIN/master 6 лет назад
Stefan Schmidt прокомментировал 6 лет назад

The usage of IP options by MembersMgmtCommAttack triggered a bug in libtins, which caused it to corrupt the contained UDP-header during the merging of the source and attack pcaps. This resulted in a partially overwritten source port in the UDP header, in this case, all packets containing the source port 36851 now had 243 as their source port (when you set the most significant byte of 36851 to zero you get 243).

The included result which the test compared to also contained this corruption, making the test break on systems unaffected by the bug. This commit simply replaces the corrupted pcap with a fixed one.

The bug was reported and fixed upstream but it will take time to trickle down to distribution packages. If the test-suite fails with AssertionError: Packets 40 differ in field UDP.sport: 243 != 36851, then you're running a version of libtins which contains the bug.

The usage of IP options by MembersMgmtCommAttack triggered a bug in libtins, which caused it to corrupt the contained UDP-header during the merging of the source and attack pcaps. This resulted in a partially overwritten source port in the UDP header, in this case, all packets containing the source port 36851 now had 243 as their source port (when you set the most significant byte of 36851 to zero you get 243). The included result which the test compared to also contained this corruption, making the test break on systems unaffected by the bug. This commit simply replaces the corrupted pcap with a fixed one. The bug was reported and fixed [upstream](https://github.com/mfontanini/libtins/issues/288) but it will take time to trickle down to distribution packages. If the test-suite fails with ```AssertionError: Packets 40 differ in field UDP.sport: 243 != 36851```, then you're running a version of libtins which contains the bug.
Слияние этого запроса успешно завершено!
Войдите, чтобы присоединиться к обсуждению.
Нет меток
Bug
Нет этапа
Нет ответственного
1 участников
Загрузка...
Отмена
Сохранить
Пока нет содержимого.