Browse Source

added comments

marius.rescheleit 4 years ago
parent
commit
4da9b08fe8
3 changed files with 10 additions and 6 deletions
  1. 1 4
      daemon/src/Server.cpp
  2. 2 0
      daemon/src/main.cpp
  3. 7 2
      daemon/src/user_manager.cpp

+ 1 - 4
daemon/src/Server.cpp

@@ -92,10 +92,7 @@ void con_handler::handle_read_login(const boost::system::error_code &err,
 
     Json::Value answer;
 
-    // user credentials
-    // TODO check user credentials!!!
-    // if (root["user"].asString().compare("user") == 0 &&
-        // root["pass"].asString().compare("pass") == 0) {
+    // check if login data is valid
     if (UserManager::isAllowed(root["user"].asString(), root["pass"].asString())) {
       answer["accept"] = true;
 

+ 2 - 0
daemon/src/main.cpp

@@ -13,6 +13,8 @@ int main(int argc, char *argv[]) {
     return 0;
   }
 
+  // check if userStorage is add specified location
+  // if not create one
   UserManager::init();
 
   const string interface = argv[1];

+ 7 - 2
daemon/src/user_manager.cpp

@@ -1,10 +1,12 @@
 #include "../include/user_manager.h"
 
 //TODO passwords are stored and checked in plain text
+//TODO read userStorage file location from config
 
 void UserManager::init() {
   std::ifstream ifile("userStorage.txt");
   if(!ifile) {
+    // create new file if userStorage does not exist
     std::ofstream file;
     file.open("userStorage.txt");
     file << "cat;tac\n";
@@ -18,6 +20,7 @@ bool UserManager::isAllowed(std::string name, std::string pw) {
   std::map<std::string,std::string> user_map;
   readFromFile(&user_map);
   auto it = user_map.find(name);
+  // check if user exists and pw is equal
   if(it!=user_map.end() && (it->second.compare(pw)==0)) {
     return true;
   }
@@ -29,6 +32,7 @@ void UserManager::addUser(std::string name, std::string pw) {
   std::map<std::string,std::string> user_map;
   readFromFile(&user_map);
   auto it = user_map.find(name);
+  // if user exists, do nothing
   if(it!=user_map.end()) {
     return;
   }
@@ -38,6 +42,7 @@ void UserManager::addUser(std::string name, std::string pw) {
 
 
 void UserManager::deleteUser(std::string name, std::string pw) {
+  // TODO check pw before delete
   std::map<std::string,std::string> user_map;
   readFromFile(&user_map);
   auto it = user_map.find(name);
@@ -48,7 +53,7 @@ void UserManager::deleteUser(std::string name, std::string pw) {
   writeToFile(&user_map);
 }
 
-
+// read content from file into given map
 void UserManager::readFromFile(std::map<std::string,std::string> *user_map) {
   std::ifstream ifile("userStorage.txt");
   std::string line;
@@ -64,7 +69,7 @@ void UserManager::readFromFile(std::map<std::string,std::string> *user_map) {
   ifile.close();
 }
 
-
+// write content from map to file
 void UserManager::writeToFile(std::map<std::string,std::string> *user_map) {
   std::ofstream file;
   file.open("userStorage.txt");