Browse Source

Removed needless TODOs

Jonas Pflanzer 4 years ago
parent
commit
3763e08f78
2 changed files with 2 additions and 4 deletions
  1. 1 1
      daemon/src/JsonCommander.cpp
  2. 1 3
      daemon/src/UserManager.cpp

+ 1 - 1
daemon/src/JsonCommander.cpp

@@ -84,7 +84,7 @@ JsonCommander::Response JsonCommander::executeList(const Json::Value &message) {
 		response.json["chunks"] = -1;
 		response.json["items"] = -1;
 		response.json["error"] = "there is already an open list command";
-	} else if ((chunks = fileManager.openList()) == -1) { // TODO do we need to check? maybe. Think about it
+	} else if ((chunks = fileManager.openList()) == -1) { // this should not happen on a current system
 		response.json["accept"] = false;
 		response.json["chunks"] = -1;
 		response.json["items"] = -1;

+ 1 - 3
daemon/src/UserManager.cpp

@@ -1,8 +1,6 @@
 #include "../include/UserManager.h"
 #include "../../libs/libbcrypt/bcrypt.h"
 
-// TODO read userStorage file location from config
-
 // initialize static filename to empty string
 std::string UserManager::filename = "";
 
@@ -66,7 +64,6 @@ bool UserManager::addUser(const std::string &name, const std::string &pw) {
 }
 
 bool UserManager::deleteUser(const std::string &name, const std::string &pw) {
-	// TODO check pw before delete
 	std::map<std::string, std::string> user_map;
 	readFromFile(user_map);
 	auto it = user_map.find(name);
@@ -74,6 +71,7 @@ bool UserManager::deleteUser(const std::string &name, const std::string &pw) {
 		return false;
 	}
 
+	// checking password before deleting
 	std::string hash = it->second;
 	if (bcrypt_checkpw(pw.c_str(), hash.c_str()) != 0) {
 		return false;