#142 Improvements for testing

Merged
carlos.garcia merged 4 commits from stefan.schmidt/test_improvements into SPIN/master 5 years ago

This mainly consists of improvements to the botnet testing mechanism. It also fixes the reported coverage being wrong (caused by running ID2T as an external process in the unittest).

  • e3b72db629: Moves "MessageType" and "Message" out of MembersMgmtCommAttack.py to improve code structure and reduce the file size. Also includes small fixes to reduce warnings in the code.
  • 9b1fbb3085: Throws out large amounts of code related to botnet testing. This was using a class that executed ID2T externally and parsed the output, which was a very fragile process. It also required a lot additional files, including binaries. I replaced it with a hash-based test (like the other attack-tests), but additional test should be added in the future.
  • d5171a9e90: Moves the pcap used for botnet testing to the same location as the other reference file.
  • 9bcfada5f6: Removes Util.MISC_OUT_FILES, which was quite a messy way to record additional files created by the attack and was causing problems when executing multiple attacks. I replaced this with a way to optionally return this list of files as a third element in the tuple returned by generate_attack_pcap().
This mainly consists of improvements to the botnet testing mechanism. It also fixes the reported coverage being wrong (caused by running ID2T as an external process in the unittest). * e3b72db62998d653f4a2abdb0619a328c4b01f28: Moves "MessageType" and "Message" out of MembersMgmtCommAttack.py to improve code structure and reduce the file size. Also includes small fixes to reduce warnings in the code. * 9b1fbb30852e169706b424922df3b4a98eebdf11: Throws out large amounts of code related to botnet testing. This was using a class that executed ID2T externally and parsed the output, which was a very fragile process. It also required a lot additional files, including binaries. I replaced it with a hash-based test (like the other attack-tests), but additional test should be added in the future. * d5171a9e9026874cab0a91b0863ce2cd464fe5bc: Moves the pcap used for botnet testing to the same location as the other reference file. * 9bcfada5f68f81ef69b8b8b45ea375f1cf72fda1: Removes Util.MISC_OUT_FILES, which was quite a messy way to record additional files created by the attack and was causing problems when executing multiple attacks. I replaced this with a way to optionally return this list of files as a third element in the tuple returned by generate_attack_pcap().
This pull request has been merged successfully!
Sign in to join this conversation.
No Milestone
No assignee
1 Participants
Loading...
Cancel
Save
There is no content yet.