Home Explore Help
Sign In
SPIN
/
ID2T-toolkit
6
5
Fork 2
Files Issues 20 Pull Requests 0 Wiki
Labels Milestones
New Pull Request

#131 Fix for incorrect capture duration

Merged
jens.klein merged 1 commits from stefan.schmidt/timestamp_fix into SPIN/master 6 years ago
Conversation 0 Commits 1 Files changed 3
Stefan Schmidt commented 6 years ago

I noticed that the capture duration was incorrect (off by one second) even after commit 971df14819, and traced it back to the C++ code not taking overflows into account when subtracting the two timestamps. I've changed the calculation to use timersub() and verified the results against Wireshark.

Tested on Arch and macOS 10.12.

I noticed that the capture duration was incorrect (off by one second) even after commit 971df14819, and traced it back to the C++ code not taking overflows into account when subtracting the two timestamps. I've changed the calculation to use timersub() and verified the results against Wireshark. Tested on Arch and macOS 10.12.
jens.klein closed 6 years ago
This pull request has been merged successfully!
Sign in to join this conversation.
Labels
Clear labels
Bug Documentation Enhancement
No Label
Bug
Documentation
Enhancement
Milestone
Clear milestone
No Milestone
Assignee
Clear assignee
No assignee
1 Participants
Write Preview
Loading...
Cancel
Save
There is no content yet.